Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2022873003: IndexedDB: Throw exception if no valid context in IDBRequest.result. (Closed)

Created:
4 years, 6 months ago by cmumford
Modified:
4 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews, blink-reviews, haraken, jsbell+idb_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Throw exception if no valid context in IDBRequest.result. This is a speculative fix since unable to repro with local Android ASan build. BUG=588352 Committed: https://crrev.com/bdb6c202d739663d6e934de598e3347ee26d215e Cr-Commit-Position: refs/heads/master@{#396907}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added exception comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
cmumford
FYI: I didn't want to use a new error message for a condition that shouldn't ...
4 years, 6 months ago (2016-05-31 17:49:39 UTC) #1
jsbell
lgtm https://codereview.chromium.org/2022873003/diff/1/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp File third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp (right): https://codereview.chromium.org/2022873003/diff/1/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp#newcode97 third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp:97: exceptionState.throwDOMException(InvalidStateError, IDBDatabase::databaseClosedErrorMessage); Maybe add comment: "Must throw if ...
4 years, 6 months ago (2016-05-31 17:56:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022873003/20001
4 years, 6 months ago (2016-05-31 18:04:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 20:06:00 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:44:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdb6c202d739663d6e934de598e3347ee26d215e
Cr-Commit-Position: refs/heads/master@{#396907}

Powered by Google App Engine
This is Rietveld 408576698