Fix scroll anchoring crash from removing an anonymous block anchor

Fix scroll anchoring crash from removing an anonymous block anchor

This CL excludes anonymous LayoutObjects when searching for an anchor.

BUG=612373
Committed: https://crrev.com/c8d4190b711d19734f7587d45e5aef227fcab93a
Cr-Commit-Position: refs/heads/master@{#397136}

[ymalik, 2016-05-30 22:43:52]

Description was changed from

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL clears the anchor node from LayoutObject::willBeDestroyed instead of
LayoutObject::willBeRemovedFromTree. The latter doesn't get called for
anonymous LayoutObjects.

BUG=612373
==========

to

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL clears the anchor node from LayoutObject::willBeDestroyed instead of
LayoutObject::willBeRemovedFromTree. The latter doesn't get called for
anonymous LayoutObjects.

BUG=612373
==========

[ymalik, 2016-05-30 22:43:52]

ymalik@chromium.org changed reviewers:
+ skobes@chromium.org

[ymalik, 2016-05-31 13:44:00]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 13:44:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022853002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022853002/1

[commit-bot: I haz the power, 2016-05-31 15:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 15:50:17]

Dry run: This issue passed the CQ dry run.

[skobes, 2016-05-31 18:22:30]

Why doesn't willBeRemovedFromTree get called for anonymous blocks?

Clearing in willBeRemovedFromTree is more efficient since there is a short
circuit when the document is being destroyed.

[ymalik, 2016-06-01 00:12:48]

Description was changed from

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL clears the anchor node from LayoutObject::willBeDestroyed instead of
LayoutObject::willBeRemovedFromTree. The latter doesn't get called for
anonymous LayoutObjects.

BUG=612373
==========

to

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL excludes anonymous LayoutObjects when searching for an anchor.

BUG=612373
==========

[ymalik, 2016-06-01 00:13:19]

Skipping anonymous objects. PTAL :)

[ymalik, 2016-06-01 00:14:00]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 00:14:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022853002/20001

[commit-bot: I haz the power, 2016-06-01 02:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 02:53:34]

Dry run: This issue passed the CQ dry run.

[skobes, 2016-06-01 04:37:30]

lgtm

[ymalik, 2016-06-01 14:25:22]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2016-06-01 14:25:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022853002/20001

[commit-bot: I haz the power, 2016-06-01 14:29:17]

Description was changed from

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL excludes anonymous LayoutObjects when searching for an anchor.

BUG=612373
==========

to

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL excludes anonymous LayoutObjects when searching for an anchor.

BUG=612373
==========

[commit-bot: I haz the power, 2016-06-01 14:29:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 14:30:40]

Description was changed from

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL excludes anonymous LayoutObjects when searching for an anchor.

BUG=612373
==========

to

==========
Fix scroll anchoring crash from removing an anonymous block anchor

This CL excludes anonymous LayoutObjects when searching for an anchor.

BUG=612373

Committed: https://crrev.com/c8d4190b711d19734f7587d45e5aef227fcab93a
Cr-Commit-Position: refs/heads/master@{#397136}
==========

[commit-bot: I haz the power, 2016-06-01 14:30:41]

Patchset 2 (id:??) landed as
https://crrev.com/c8d4190b711d19734f7587d45e5aef227fcab93a
Cr-Commit-Position: refs/heads/master@{#397136}