Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5886)

Unified Diff: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Issue 2022783002: Skeleton of the Safe Browsing Subresource Filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from battre@. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/subresource_filter/subresource_filter_browsertest.cc
diff --git a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..123c9f704f82b8bf8a54185753394a035e410ad7
--- /dev/null
+++ b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
@@ -0,0 +1,80 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
Mike West 2016/06/01 13:43:17 Why is this in //chrome/browser/subresource_filter
engedy 2016/06/01 21:00:44 This is awkward indeed, but there seems to be no b
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/files/file_path.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "components/subresource_filter/core/browser/subresource_filter_features.h"
+#include "components/subresource_filter/core/browser/subresource_filter_features_test_support.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace subresource_filter {
+
+using subresource_filter::testing::ScopedSubresourceFilterFeatureToggle;
+
+class SubresourceFilterBrowserTest : public InProcessBrowserTest {
+ public:
+ SubresourceFilterBrowserTest() {}
+ ~SubresourceFilterBrowserTest() override {}
+
+ protected:
+ void SetUpOnMainThread() override {
+ scoped_feature_toggle_.reset(new ScopedSubresourceFilterFeatureToggle(
+ base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationStateEnabled));
+ }
+
+ content::WebContents* web_contents() {
+ return browser()->tab_strip_model()->GetActiveWebContents();
+ }
+
+ content::RenderFrameHost* FindFrameByName(const std::string& name) {
+ for (content::RenderFrameHost* frame : web_contents()->GetAllFrames()) {
+ if (frame->GetFrameName() == name)
+ return frame;
+ }
+ return nullptr;
+ }
+
+ void ExpectScriptResourceWasNotLoaded(content::RenderFrameHost* rfh) {
+ bool script_resource_was_not_loaded;
+ ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
+ rfh, "domAutomationController.send(!document.scriptExecuted)",
+ &script_resource_was_not_loaded));
+ EXPECT_TRUE(script_resource_was_not_loaded);
+ }
+
+ private:
+ std::unique_ptr<ScopedSubresourceFilterFeatureToggle> scoped_feature_toggle_;
+
+ DISALLOW_COPY_AND_ASSIGN(SubresourceFilterBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest, MainFrameActivation) {
+ const GURL url(ui_test_utils::GetTestUrl(
+ base::FilePath().AppendASCII("subresource_filter"),
+ base::FilePath().AppendASCII("frame_with_included_script.html")));
+ ui_test_utils::NavigateToURL(browser(), url);
+ ExpectScriptResourceWasNotLoaded(web_contents()->GetMainFrame());
+}
+
+IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest, SubFrameActivation) {
+ const GURL url(ui_test_utils::GetTestUrl(
+ base::FilePath().AppendASCII("subresource_filter"),
+ base::FilePath().AppendASCII("frame_set.html")));
+ ui_test_utils::NavigateToURL(browser(), url);
+
+ const char* kSubframeNames[] = {"one", "two"};
+ for (const char* subframe_name : kSubframeNames) {
+ content::RenderFrameHost* frame = FindFrameByName(subframe_name);
+ ASSERT_TRUE(frame);
+ ExpectScriptResourceWasNotLoaded(frame);
+ }
+}
+
+} // namespace subresource_filter

Powered by Google App Engine
This is Rietveld 408576698