third_party/WebKit/LayoutTests/TestExpectations - Issue 2022783002: Skeleton of the Safe Browsing Subresource Filter.

Side by Side Diff: third_party/WebKit/LayoutTests/TestExpectations

Issue 2022783002: Skeleton of the Safe Browsing Subresource Filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from battre@. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/test_runner/test_runner.cc ('K') | « ipc/ipc_message_start.h ('k') | third_party/WebKit/LayoutTests/http/tests/subresource_filter/resource-allowed.html » ('j') | third_party/WebKit/LayoutTests/http/tests/subresource_filter/resource-allowed.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # ====== Oilpan-only failures from here ======	1 # ====== Oilpan-only failures from here ======

2 # Most of these actually cause the tests to report success, rather than	2 # Most of these actually cause the tests to report success, rather than

3 # failure. Expected outputs will be adjusted for the better once Oilpan	3 # failure. Expected outputs will be adjusted for the better once Oilpan

4 # has been well and truly enabled always.	4 # has been well and truly enabled always.

5	5

6 crbug.com/501229 fast/forms/associatedFormControls-leak-nodes.html [ Failure Pas s ]	6 crbug.com/501229 fast/forms/associatedFormControls-leak-nodes.html [ Failure Pas s ]

7	7

8 crbug.com/420008 inspector/tracing/worker-js-frames.html [ Pass Timeout Failure ]	8 crbug.com/420008 inspector/tracing/worker-js-frames.html [ Pass Timeout Failure ]

9 crbug.com/420008 virtual/threaded/inspector/tracing/worker-js-frames.html [ Pass Timeout Failure ]	9 crbug.com/420008 virtual/threaded/inspector/tracing/worker-js-frames.html [ Pass Timeout Failure ]

10 crbug.com/596940 inspector-protocol/runtime/runtime-execution-contexts-events.ht ml [ Pass Timeout ]	10 crbug.com/596940 inspector-protocol/runtime/runtime-execution-contexts-events.ht ml [ Pass Timeout ]

(...skipping 1370 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1381 crbug.com/609067 [ Mac ] bluetooth/writeValue/blacklisted-characteristic.html [ Skip ]	1381 crbug.com/609067 [ Mac ] bluetooth/writeValue/blacklisted-characteristic.html [ Skip ]

1382 crbug.com/609067 [ Mac ] bluetooth/writeValue/characteristic-is-removed.html [ S kip ]	1382 crbug.com/609067 [ Mac ] bluetooth/writeValue/characteristic-is-removed.html [ S kip ]

1383 crbug.com/609067 [ Mac ] bluetooth/writeValue/device-goes-out-of-range.html [ Sk ip ]	1383 crbug.com/609067 [ Mac ] bluetooth/writeValue/device-goes-out-of-range.html [ Sk ip ]

1384 crbug.com/609067 [ Mac ] bluetooth/writeValue/service-is-removed.html [ Skip ]	1384 crbug.com/609067 [ Mac ] bluetooth/writeValue/service-is-removed.html [ Skip ]

1385 crbug.com/609067 [ Mac ] bluetooth/writeValue/value-too-long.html [ Skip ]	1385 crbug.com/609067 [ Mac ] bluetooth/writeValue/value-too-long.html [ Skip ]

1386 crbug.com/609067 [ Mac ] bluetooth/writeValue/write-fails.html [ Skip ]	1386 crbug.com/609067 [ Mac ] bluetooth/writeValue/write-fails.html [ Skip ]

1387 crbug.com/609067 [ Mac ] bluetooth/writeValue/write-succeeds.html [ Skip ]	1387 crbug.com/609067 [ Mac ] bluetooth/writeValue/write-succeeds.html [ Skip ]

1388 crbug.com/609067 [ Mac ] bluetooth/writeValue/write-updates-value.html [ Skip ]	1388 crbug.com/609067 [ Mac ] bluetooth/writeValue/write-updates-value.html [ Skip ]

1389	1389

1390 crbug.com/610567 usb/usbDevice-iframe.html [ Failure Pass Timeout ]	1390 crbug.com/610567 usb/usbDevice-iframe.html [ Failure Pass Timeout ]

	1391

	1392 crbug.com/609747 http/tests/subresource_filter [ NeedsRebaseline ]
	Mike West 2016/06/01 13:43:18 This is not a great way to land tests: if the test This is not a great way to land tests: if the tests are broken, this will just mindless write new expectation files. You should generate those expectations locally, verify that they are correct, and commit them along with the CL. Or just use testharness-style assertions, and forget about expectation files entirely. engedy 2016/06/02 23:07:19 Done. Out of curiosity, what's the preferred way Show quoted text On 2016/06/01 13:43:18, Mike West (OOO until 30th) wrote: > This is not a great way to land tests: if the tests are broken, this will just > mindless write new expectation files. You should generate those expectations > locally, verify that they are correct, and commit them along with the CL. > > Or just use testharness-style assertions, and forget about expectation files > entirely. Done. Out of curiosity, what's the preferred way to create platform-dependent pixel test expectations?
OLD	NEW