components/subresource_filter/content/common/subresource_filter_messages.h - Issue 2022783002: Skeleton of the Safe Browsing Subresource Filter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/subresource_filter/content/common/subresource_filter_messages.h

Issue 2022783002: Skeleton of the Safe Browsing Subresource Filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from battre@. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/subresource_filter/subresource_filter_browsertest.cc ('K') | « components/subresource_filter/content/common/subresource_filter_message_generator.cc ('k') | components/subresource_filter/content/renderer/BUILD.gn » ('j') | components/test_runner/test_runner.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Message definition file, included multiple times, hence no include guard.

	6

	7 #include "components/subresource_filter/core/common/activation_state.h"

	8 #include "content/public/common/common_param_traits_macros.h"

	9 #include "ipc/ipc_message_macros.h"

	10 #include "ipc/ipc_message.h"

	11

	12 #define IPC_MESSAGE_START SubresourceFilterMsgStart

	13

	14 IPC_ENUM_TRAITS_MAX_VALUE(subresource_filter::ActivationState,

	15 subresource_filter::ActivationState::LAST);

	16

	17 // ----------------------------------------------------------------------------

	18 // Messages sent from the browser to the renderer.

	19 // ----------------------------------------------------------------------------

	20

	21 // Instructs the renderer to activate subresource filtering for the currently

	22 // ongoing provisional document load in a frame. The message must arrive after

	23 // the provisional load starts, but before it is committed on the renderer side.

	24 // If no message arrives, the default behavior is ActivationState::DISABLED.

	25 IPC_MESSAGE_ROUTED1(SubresourceFilterAgentMsg_ActivateForProvisionalLoad,

	26 subresource_filter::ActivationState);
	jochen (gone - plz use gerrit) 2016/06/01 15:23:33 any reason this is not using mojo ipc? any reason this is not using mojo ipc? engedy 2016/06/01 21:00:44 Yes. Mojo does not currently provide FIFO ordering Show quoted text On 2016/06/01 15:23:33, jochen wrote: > any reason this is not using mojo ipc? Yes. Mojo does not currently provide FIFO ordering between Mojo and legacy IPC messages [1], and here we need a guarantee that this message arrives to the renderer before ResourceMsg_DataReceived. Otherwise the provisional might be committed and subresource loads might already be in flight at the time the filter is activated. [1]: https://groups.google.com/a/chromium.org/d/topic/chromium-mojo/h6L7KSxpl8E/di...
OLD	NEW