Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2022753002: [turbofan] Fix NumberIsHoleNaN to check the upper word. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix NumberIsHoleNaN to check the upper word. The NumberIsHoleNaN operator used to test the lower word of the double input which is obviously wrong. R=jarin@chromium.org Committed: https://crrev.com/496aecb61fefc9b8fd3399ca265b997300f627ef Cr-Commit-Position: refs/heads/master@{#36584}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/compiler/simplified-lowering.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
A + test/mjsunit/compiler/regress-number-is-hole-nan.js View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-05-30 11:20:02 UTC) #1
Jarin
lgtm https://codereview.chromium.org/2022753002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2022753002/diff/1/src/compiler/simplified-lowering.cc#newcode1095 src/compiler/simplified-lowering.cc:1095: // #HoleNabUpperr32) HoleNabUpperr32 -> HoleNaNUpper32
4 years, 6 months ago (2016-05-30 11:21:39 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/2022753002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2022753002/diff/1/src/compiler/simplified-lowering.cc#newcode1095 src/compiler/simplified-lowering.cc:1095: // #HoleNabUpperr32) On 2016/05/30 11:21:38, Jarin wrote: > HoleNabUpperr32 ...
4 years, 6 months ago (2016-05-30 11:21:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022753002/20001
4 years, 6 months ago (2016-05-30 11:22:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-30 11:46:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 11:48:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/496aecb61fefc9b8fd3399ca265b997300f627ef
Cr-Commit-Position: refs/heads/master@{#36584}

Powered by Google App Engine
This is Rietveld 408576698