Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/crankshaft/hydrogen-instructions.h

Issue 2022743002: [crankshaft] There is no guarantee that allocations are folded in Crankshaft. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.h
diff --git a/src/crankshaft/hydrogen-instructions.h b/src/crankshaft/hydrogen-instructions.h
index fdb1fd6d46c5cea8a8f77458d8297f5e8980b51d..f3d0b974ae27d856212966648abed1f67802ed74 100644
--- a/src/crankshaft/hydrogen-instructions.h
+++ b/src/crankshaft/hydrogen-instructions.h
@@ -5148,8 +5148,11 @@ inline bool ReceiverObjectNeedsWriteBarrier(HValue* object,
HAllocate* allocate = HAllocate::cast(object);
if (allocate->IsAllocationFolded()) {
HValue* dominator = allocate->allocation_folding_dominator();
- DCHECK(HAllocate::cast(dominator)->IsAllocationFoldingDominator());
- object = dominator;
+ // There is no guarantee that all allocations are folded together because
+ // GVN performs a fixpoint.
+ if (HAllocate::cast(dominator)->IsAllocationFoldingDominator()) {
+ object = dominator;
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698