Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2022723002: Move VisibleSelection::positionRespectingEditingBoundary() to EditingUtilities.cpp (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VisibleSelection::positionRespectingEditingBoundary() to EditingUtilities.cpp This patch moves a member function |positionRespectingEditingBoundary()| in |VisibleSelection| and gets rid of |visiblePositionRespectingEditingBoundary()| to simplify |VisibleSelection| class for improving code health, since these functions are used in one place. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/1ee44ea93271409b790999e882d05c0666a89850 Cr-Commit-Position: refs/heads/master@{#396779}

Patch Set 1 : 2016-05-30T17:10:26 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -32 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-05-30 09:19:17 UTC) #3
yoichio
lgtm
4 years, 3 months ago (2016-05-31 01:56:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022723002/1
4 years, 3 months ago (2016-05-31 03:54:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-05-31 03:58:40 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 04:00:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ee44ea93271409b790999e882d05c0666a89850
Cr-Commit-Position: refs/heads/master@{#396779}

Powered by Google App Engine
This is Rietveld 408576698