chrome/browser/devtools/devtools_ui_bindings.cc - Issue 2022673002: DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2022673002: DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make it more generic Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index 470220f8535f14e7d5a0fdbade89dca7fe4f589d..f40c7034c3634bbb0e034739d2bbab2ce4242b76 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -466,9 +466,9 @@ void DevToolsUIBindings::DispatchProtocolMessage(

DCHECK(agent_host == agent_host_.get());

if (message.length() < kMaxMessageChunkSize) {

- base::string16 javascript = base::UTF8ToUTF16(

- "DevToolsAPI.dispatchMessage(" + message + ");");

- web_contents_->GetMainFrame()->ExecuteJavaScript(javascript);

+ base::StringValue message_value(message);

+ CallClientFunction("DevToolsAPI.dispatchMessage", &message_value, NULL,

+ NULL);

return;

}

« no previous file with comments | « no previous file | content/shell/browser/shell_devtools_frontend.cc » ('j') | content/shell/browser/shell_devtools_frontend.cc » ('J')