Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2022613002: cc: Restore the space of interest area padding to be ideal contents space. (Closed)

Created:
4 years, 6 months ago by vmpstr
Modified:
4 years, 6 months ago
Reviewers:
enne (OOO), ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Restore the space of interest area padding to be ideal contents space. This patch ensures that the interest area padding we use is specified in ideal contents scale, not in screen scale. Effectively this means that on devices with content scale > 1, we will have a smaller interest area. This restores the behavior that was changed when the calculation was moved to the tiling set. R=ericrk, enne BUG=614990 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/55a6f3c6ead8ab53ff8b0a1ea5953971d3e272a3 Cr-Commit-Position: refs/heads/master@{#396602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/tiles/picture_layer_tiling_set.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vmpstr
Please take a look.
4 years, 6 months ago (2016-05-27 21:58:31 UTC) #2
ericrk
lgtm
4 years, 6 months ago (2016-05-27 22:06:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022613002/1
4 years, 6 months ago (2016-05-27 22:09:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 23:44:25 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 23:46:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55a6f3c6ead8ab53ff8b0a1ea5953971d3e272a3
Cr-Commit-Position: refs/heads/master@{#396602}

Powered by Google App Engine
This is Rietveld 408576698