Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2022563002: Remove display item scope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
index 00ff50cdf75da0c175d948129870e08409989320..4ff3c540b6c1630ddf9e867ab607010957c1b3b7 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
@@ -89,12 +89,6 @@ public:
createAndAppend<DisplayItemClass>(std::forward<Args>(args)...);
}
- // Scopes must be used to avoid duplicated display item ids when we paint some object
- // multiple times and generate multiple display items with the same type.
- // We don't cache display items added in scopes.
- void beginScope();
- void endScope();
-
// True if the last display item is a begin that doesn't draw content.
bool lastDisplayItemIsNoopBegin() const;
void removeLastDisplayItem();
@@ -161,11 +155,10 @@ protected:
, m_imagePainted(false)
, m_skippingCacheCount(0)
, m_numCachedNewItems(0)
- , m_nextScope(1)
{ }
private:
- // Set new item state (scopes, cache skipping, etc) for a new item.
+ // Set new item state (cache skipping, etc) for a new item.
void processNewItem(DisplayItem&);
#ifndef NDEBUG
@@ -223,9 +216,6 @@ private:
int m_numCachedNewItems;
- unsigned m_nextScope;
- Vector<unsigned> m_scopeStack;
-
#if DCHECK_IS_ON()
// Record the debug names of invalidated clients for assertion and debugging.
Vector<String> m_invalidations;

Powered by Google App Engine
This is Rietveld 408576698