third_party/WebKit/Source/platform/graphics/paint/README.md - Issue 2022563002: Remove display item scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/README.md

Issue 2022563002: Remove display item scope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/paint/README.md

diff --git a/third_party/WebKit/Source/platform/graphics/paint/README.md b/third_party/WebKit/Source/platform/graphics/paint/README.md

index 28d916d9e3f5d8aaef29c0a7359e4b018d7a2352..8756e10874939de22dd2f0a2d3ecdde037a88836 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/README.md

+++ b/third_party/WebKit/Source/platform/graphics/paint/README.md

@@ -118,11 +118,6 @@ item is identified by an ID consisting of:

* an opaque pointer to the *display item client* that produced it

* a type (from the `DisplayItem::Type` enum)

-* a scope number

-*** aside

-TODO(jbroman): Explain scope numbers.

-***

In practice, display item clients are generally subclasses of `LayoutObject`,

but can be other Blink objects which get painted, such as inline boxes and drag

@@ -130,7 +125,8 @@ images.

*** note

It is illegal for there to be two drawings with the same ID in a display item

-list.

+list, except that the drawings are marked uncacheable

chrishtr 2016/05/31 21:07:07 Nit: "except for drawings that are marked uncachea

Xianzhu 2016/05/31 21:42:39 Done.

+(see [DisplayItemCacheSkipper](DisplayItemCacheSkipper.h)).

***

Generally, clients of this code should use stack-allocated recorder classes to