[Android] Add --adb-path option for tombstones.py.

[Android] Add --adb-path option for tombstones.py.

BUG=526305
Committed: https://crrev.com/3e0f4b217906154d47d3e7470d3ac7e3cb4a39ef
Cr-Commit-Position: refs/heads/master@{#396636}

[jbudorick, 2016-05-27 20:00:01]

jbudorick@chromium.org changed reviewers:
+ mikecase@chromium.org, rnephew@chromium.org

[mikecase (-- gone --), 2016-05-28 00:57:12]

lgtm

https://codereview.chromium.org/2022533002/diff/1/build/android/tombstones.py
File build/android/tombstones.py (right):

https://codereview.chromium.org/2022533002/diff/1/build/android/tombstones.py...
build/android/tombstones.py:244: parser.add_option('--adb-path', help='Absolute
path to the adb binary.')
Have you considered enforcing this is os.path.isabs?

[jbudorick, 2016-05-28 01:27:31]

https://codereview.chromium.org/2022533002/diff/1/build/android/tombstones.py
File build/android/tombstones.py (right):

https://codereview.chromium.org/2022533002/diff/1/build/android/tombstones.py...
build/android/tombstones.py:244: parser.add_option('--adb-path', help='Absolute
path to the adb binary.')
On 2016/05/28 00:57:12, mikecase wrote:
> Have you considered enforcing this is os.path.isabs?

I hadn't. I instead made the script make the path absolute and removed
"absolute" from the help text.

[jbudorick, 2016-05-28 01:27:36]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-05-28 01:27:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2022533002/#ps40001
(title: "abspath everywhere")

[commit-bot: I haz the power, 2016-05-28 01:27:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022533002/40001

[commit-bot: I haz the power, 2016-05-28 02:07:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 02:07:08]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jbudorick, 2016-05-28 02:22:31]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-05-28 02:22:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2022533002/#ps60001
(title: "argparse for tombstones.py and type=os.path.abspath")

[commit-bot: I haz the power, 2016-05-28 02:22:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022533002/60001

[commit-bot: I haz the power, 2016-05-28 04:49:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-28 04:51:39]

Description was changed from

==========
[Android] Add --adb-path option for tombstones.py.

BUG=526305
==========

to

==========
[Android] Add --adb-path option for tombstones.py.

BUG=526305

Committed: https://crrev.com/3e0f4b217906154d47d3e7470d3ac7e3cb4a39ef
Cr-Commit-Position: refs/heads/master@{#396636}
==========

[commit-bot: I haz the power, 2016-05-28 04:51:41]

Patchset 4 (id:??) landed as
https://crrev.com/3e0f4b217906154d47d3e7470d3ac7e3cb4a39ef
Cr-Commit-Position: refs/heads/master@{#396636}