Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2022513002: Reorder Future.then checks in StrongTypeSystemImpl. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reorder Future.then checks in StrongTypeSystemImpl. It is usually slightly faster to check isNotEmpty then to validate isFutureThen condition. R=brianwilkerson@google.com, jmesserly@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/29f44a502bd49d24739acd6f90ba443c845b1afb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 6 months ago (2016-05-27 19:22:25 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-05-27 21:17:11 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 29f44a502bd49d24739acd6f90ba443c845b1afb (presubmit successful).
4 years, 6 months ago (2016-05-29 19:17:46 UTC) #4
Jennifer Messerly
4 years, 6 months ago (2016-06-06 20:45:36 UTC) #5
Message was sent while issue was closed. 
Good catch, great change. Thank you :)

Powered by Google App Engine
This is Rietveld 408576698