Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: content/public/browser/navigation_controller.h

Issue 2022483003: ABANDONED CL: LoadURLParams: Add |method| + removing LOAD_TYPE_BROWSER_INITIATED_HTTP_POST. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@post-data-my-stuff
Patch Set: Rebasing... Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_controller.h
diff --git a/content/public/browser/navigation_controller.h b/content/public/browser/navigation_controller.h
index e3673d123090619ef6eda93f030394ff8831a83c..d7895f332d118096ce24ed2f1b846a898ce2cb0d 100644
--- a/content/public/browser/navigation_controller.h
+++ b/content/public/browser/navigation_controller.h
@@ -65,10 +65,6 @@ class NavigationController {
// For loads that do not fall into any types below.
LOAD_TYPE_DEFAULT,
- // An http post load request initiated from browser side.
- // The post data is passed in |browser_initiated_post_data|.
- LOAD_TYPE_BROWSER_INITIATED_HTTP_POST,
-
// Loads a 'data:' scheme URL with specified base URL and a history entry
// URL. This is only safe to be used for browser-initiated data: URL
// navigations, since it shows arbitrary content as if it comes from
@@ -125,6 +121,9 @@ class NavigationController {
// The url to load. This field is required.
GURL url;
+ // HTTP method to use.
+ std::string method = "GET";
+
// SiteInstance of the frame that initiated the navigation or null if we
// don't know it.
scoped_refptr<SiteInstance> source_site_instance;
@@ -178,9 +177,9 @@ class NavigationController {
scoped_refptr<base::RefCountedString> data_url_as_string;
#endif
- // Used in LOAD_TYPE_BROWSER_INITIATED_HTTP_POST loads only. Carries the
- // post data of the load. Ownership is transferred to NavigationController
- // after LoadURLWithParams call.
+ // Used only if method == "POST". Carries the post data of the load.
+ // Ownership is transferred to NavigationController after LoadURLWithParams
+ // call.
scoped_refptr<base::RefCountedMemory> browser_initiated_post_data;
// True if this URL should be able to access local resources.

Powered by Google App Engine
This is Rietveld 408576698