Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2022453003: bot_update: remove activation check for non-masters (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

bot_update: remove activation check for non-masters Cherry-pick https://codereview.chromium.org/2000403004/ to depot_tools's bot_update.py R=hinoka@chromium.org BUG=613641 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nodir
PTAL It is exactly same diff
4 years, 6 months ago (2016-05-27 21:58:10 UTC) #1
hinoka
lgtm
4 years, 6 months ago (2016-05-27 22:07:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022453003/1
4 years, 6 months ago (2016-05-27 22:09:08 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 22:12:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300670

Powered by Google App Engine
This is Rietveld 408576698