Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2022363002: Revert of Remove obsolete StoragePartition check from old iframe signin path. (Closed)

Created:
4 years, 6 months ago by caseq
Modified:
4 years, 6 months ago
CC:
chromium-reviews, clamy, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove obsolete StoragePartition check from old iframe signin path. (patchset #2 id:20001 of https://codereview.chromium.org/2007223003/ ) Reason for revert: This broke DevTools, please see bug for more details. BUG=616282 Original issue's description: > Remove obsolete StoragePartition check from old iframe signin path. > > BUG=614808 > TEST=Signin still works. > > Committed: https://crrev.com/1fa5e60dc33595d1bc56f0452370ee66feb544db > Cr-Commit-Position: refs/heads/master@{#396193} TBR=anthonyvd@chromium.org,dbeam@chromium.org,creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=614808 Committed: https://crrev.com/4b1fa12663f7169c0868dee60c978acfaa6fd1e2 Cr-Commit-Position: refs/heads/master@{#397006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -10 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 3 chunks +64 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
caseq
Created Revert of Remove obsolete StoragePartition check from old iframe signin path.
4 years, 6 months ago (2016-05-31 23:20:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022363002/1
4 years, 6 months ago (2016-05-31 23:21:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 01:00:11 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:01:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b1fa12663f7169c0868dee60c978acfaa6fd1e2
Cr-Commit-Position: refs/heads/master@{#397006}

Powered by Google App Engine
This is Rietveld 408576698