Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2022343003: Add client.webrtc.perf master (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add client.webrtc.perf master The builders currently added are just samples. They'll be replaced with actual ones when we've figured out which machines shall be used. BUG=616531 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c7b17496fe54413e9ba25899bfe94b66cede30a4

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -12 lines) Patch
A + masters/master.client.webrtc.perf/Makefile View 1 chunk +1 line, -1 line 0 comments Download
A + masters/master.client.webrtc.perf/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.client.webrtc.perf/buildbot View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.client.webrtc.perf/buildbot.tac View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.client.webrtc.perf/master.cfg View 3 chunks +46 lines, -13 lines 1 comment Download
A masters/master.client.webrtc.perf/master_site_config.py View 1 chunk +19 lines, -0 lines 3 comments Download
A + masters/master.client.webrtc.perf/master_source_cfg.py View 1 chunk +1 line, -1 line 0 comments Download
A masters/master.client.webrtc.perf/slaves.cfg View 1 chunk +72 lines, -0 lines 0 comments Download
A masters/master.client.webrtc.perf/templates/description.html View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/masters_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kjellander_chromium
https://codereview.chromium.org/2022343003/diff/40001/masters/master.client.webrtc.perf/master_site_config.py File masters/master.client.webrtc.perf/master_site_config.py (right): https://codereview.chromium.org/2022343003/diff/40001/masters/master.client.webrtc.perf/master_site_config.py#newcode11 masters/master.client.webrtc.perf/master_site_config.py:11: master_port = 20301 These ports were generated with $ ...
4 years, 6 months ago (2016-06-01 18:11:40 UTC) #4
ghost stip (do not use)
generally lg, but you should really look into builders.pyl: https://chromium.googlesource.com/infra/infra/+/master/doc/users/services/buildbot/builders.pyl.md#Example https://chromiumcodereview.appspot.com/2022343003/diff/40001/masters/master.client.webrtc.perf/master.cfg File masters/master.client.webrtc.perf/master.cfg (right): https://chromiumcodereview.appspot.com/2022343003/diff/40001/masters/master.client.webrtc.perf/master.cfg#newcode29 ...
4 years, 6 months ago (2016-06-01 18:43:49 UTC) #5
ghost stip (do not use)
+ friedman@ in case he needs to screen the ports
4 years, 6 months ago (2016-06-01 18:44:09 UTC) #8
friedman
lgtm https://chromiumcodereview.appspot.com/2022343003/diff/40001/masters/master.client.webrtc.perf/master_site_config.py File masters/master.client.webrtc.perf/master_site_config.py (right): https://chromiumcodereview.appspot.com/2022343003/diff/40001/masters/master.client.webrtc.perf/master_site_config.py#newcode11 masters/master.client.webrtc.perf/master_site_config.py:11: master_port = 20301 On 2016/06/01 18:43:49, stip wrote: ...
4 years, 6 months ago (2016-06-01 18:46:57 UTC) #9
friedman
On 2016/06/01 18:46:57, friedman wrote: > lgtm > > https://chromiumcodereview.appspot.com/2022343003/diff/40001/masters/master.client.webrtc.perf/master_site_config.py > File masters/master.client.webrtc.perf/master_site_config.py (right): > ...
4 years, 6 months ago (2016-06-01 18:47:10 UTC) #10
kjellander_chromium
On 2016/06/01 18:43:49, stip wrote: > generally lg, but you should really look into builders.pyl: ...
4 years, 6 months ago (2016-06-01 18:50:01 UTC) #11
ghost stip (do not use)
lgtm :)
4 years, 6 months ago (2016-06-01 23:28:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022343003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022343003/40001
4 years, 6 months ago (2016-06-02 07:07:47 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 07:12:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/c7b17496fe54413e9ba2...

Powered by Google App Engine
This is Rietveld 408576698