chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java - Issue 2022313002: UI for the Data Saver InfoBar Promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

Issue 2022313002: UI for the Data Saver InfoBar Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobarPromo

Patch Set: use app_icon Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionPromoInfoBarDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionPromoInfoBarDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java » ('j') | chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

index 0c10d0b8d752f995ac9cd359fe63b76e67e96e00..8c5fa3be56926588abeb312f2791001115579c5d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

@@ -19,6 +19,8 @@ import android.widget.LinearLayout.LayoutParams;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;

import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;

+import org.chromium.chrome.browser.preferences.PrefServiceBridge;

+import org.chromium.chrome.browser.preferences.PrefServiceBridge.AboutVersionStrings;

import org.chromium.ui.widget.Toast;

/**

@@ -112,7 +114,10 @@ public class DataReductionPromoScreen extends Dialog implements View.OnClickList

@Override

public void onDismiss(DialogInterface dialog) {

- DataReductionPromoUtils.saveFreOrSecondRunPromoDisplayed();

+ AboutVersionStrings versionStrings = PrefServiceBridge.getInstance()

Raj 2016/06/13 17:52:18 Same as previous comment. Can the version be obtai

megjablon 2016/06/23 23:17:30 Done.

+ .getAboutVersionStrings();

+ DataReductionPromoUtils

+ .saveFreOrSecondRunPromoDisplayed(versionStrings.getApplicationVersion());

}

private void handleEnableButtonPressed() {