Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2022283004: Empty list of payment methods should throw TypeError. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Empty list of payment methods should throw TypeError. This patch ensures that an empty list of payment methods should throw a TypeError. Before this patch, any type of error would pass the test. The code under test: new PaymentRequest([], buildDetails()); BUG=587995 Committed: https://crrev.com/e98a33075ec069bad2924c2bfb6f610e13a67aa9 Cr-Commit-Position: refs/heads/master@{#397004}

Patch Set 1 #

Total comments: 2

Patch Set 2 : New TypeError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
please use gerrit instead
mek@, ptal.
4 years, 6 months ago (2016-05-31 21:57:55 UTC) #2
Marijn Kruisselbrink
lgtm pretty much all those assert_throws tests seem like they should throw a TypeError. Any ...
4 years, 6 months ago (2016-05-31 22:11:24 UTC) #3
please use gerrit instead
On 2016/05/31 22:11:24, Marijn Kruisselbrink wrote: > pretty much all those assert_throws tests seem like ...
4 years, 6 months ago (2016-05-31 23:20:24 UTC) #4
please use gerrit instead
https://codereview.chromium.org/2022283004/diff/1/third_party/WebKit/LayoutTests/payments/payment-request-interface.html File third_party/WebKit/LayoutTests/payments/payment-request-interface.html (right): https://codereview.chromium.org/2022283004/diff/1/third_party/WebKit/LayoutTests/payments/payment-request-interface.html#newcode127 third_party/WebKit/LayoutTests/payments/payment-request-interface.html:127: ['Empty list of supported payment method identifiers should throw ...
4 years, 6 months ago (2016-05-31 23:20:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022283004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022283004/20001
4 years, 6 months ago (2016-05-31 23:22:01 UTC) #8
Marijn Kruisselbrink
On 2016/05/31 at 23:20:24, rouslan wrote: > On 2016/05/31 22:11:24, Marijn Kruisselbrink wrote: > > ...
4 years, 6 months ago (2016-05-31 23:32:52 UTC) #9
please use gerrit instead
On 2016/05/31 23:32:52, Marijn Kruisselbrink wrote: > keep in mind that for some of these ...
4 years, 6 months ago (2016-05-31 23:37:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 00:58:46 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:00:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e98a33075ec069bad2924c2bfb6f610e13a67aa9
Cr-Commit-Position: refs/heads/master@{#397004}

Powered by Google App Engine
This is Rietveld 408576698