components/offline_pages/client_policy_controller_unittest.cc - Issue 2022283003: Record offline histograms with suffix via Histogram::FactoryGet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/client_policy_controller_unittest.cc

Issue 2022283003: Record offline histograms with suffix via Histogram::FactoryGet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change to use Histogram::FactoryGet Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/client_namespace_constants.h ('K') | « components/offline_pages/client_policy_controller.cc ('k') | components/offline_pages/offline_page_model.h » ('j') | components/offline_pages/offline_page_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/client_policy_controller_unittest.cc

diff --git a/components/offline_pages/client_policy_controller_unittest.cc b/components/offline_pages/client_policy_controller_unittest.cc

index 6bd4faeffd7578b22c51d354fddf595140fd5eb1..918de56d593bb0cecacdc8e0fe55917f63604417 100644

--- a/components/offline_pages/client_policy_controller_unittest.cc

+++ b/components/offline_pages/client_policy_controller_unittest.cc

@@ -6,6 +6,7 @@

#include "base/bind.h"

#include "base/time/time.h"

+#include "components/offline_pages/client_namespace_constants.h"

#include "testing/gtest/include/gtest/gtest.h"

using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;

@@ -13,8 +14,6 @@ using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;

namespace offline_pages {

namespace {

-const char kBookmarkNamespace[] = "bookmark";

-const char kLastNNamespace[] = "last_n";

const char kUndefinedNamespace[] = "undefined";

bool isTemporary(const OfflinePageClientPolicy& policy) {