components/offline_pages/client_policy_controller_unittest.cc - Issue 2022283003: Record offline histograms with suffix via Histogram::FactoryGet

Unified Diff: components/offline_pages/client_policy_controller_unittest.cc

Issue 2022283003: Record offline histograms with suffix via Histogram::FactoryGet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/client_policy_controller.cc ('k') | components/offline_pages/offline_page_model.h » ('j') | components/offline_pages/offline_page_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/client_policy_controller_unittest.cc

diff --git a/components/offline_pages/client_policy_controller_unittest.cc b/components/offline_pages/client_policy_controller_unittest.cc

index 6bd4faeffd7578b22c51d354fddf595140fd5eb1..918de56d593bb0cecacdc8e0fe55917f63604417 100644

--- a/components/offline_pages/client_policy_controller_unittest.cc

+++ b/components/offline_pages/client_policy_controller_unittest.cc

@@ -6,6 +6,7 @@

#include "base/bind.h"

#include "base/time/time.h"

+#include "components/offline_pages/client_namespace_constants.h"

#include "testing/gtest/include/gtest/gtest.h"

using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;

@@ -13,8 +14,6 @@ using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;

namespace offline_pages {

namespace {

-const char kBookmarkNamespace[] = "bookmark";

-const char kLastNNamespace[] = "last_n";

const char kUndefinedNamespace[] = "undefined";

chili 2016/05/31 21:51:33 should we also move undefined to the namespace con

dewittj 2016/05/31 22:38:45 Don't think so, this is just for testing.

dewittj 2016/05/31 23:12:01 actually I think you're right now that I look at i

jianli 2016/05/31 23:50:07 I think this is only used in testing code and it c

dewittj 2016/06/01 00:04:12 got it... This is different from kDefaultNamespace

bool isTemporary(const OfflinePageClientPolicy& policy) {