components/offline_pages/client_namespace_constants.h - Issue 2022283003: Record offline histograms with suffix via Histogram::FactoryGet

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/client_namespace_constants.h

Issue 2022283003: Record offline histograms with suffix via Histogram::FactoryGet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change to use Histogram::FactoryGet Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/net/net_error_tab_helper.cc ('K') | « components/offline_pages/BUILD.gn ('k') | components/offline_pages/client_namespace_constants.cc » ('j') | components/offline_pages/offline_page_model.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_OFFLINE_PAGES_CLIENT_NAMESPACE_CONSTANTS_H_

	6 #define COMPONENTS_OFFLINE_PAGES_CLIENT_NAMESPACE_CONSTANTS_H_

	7

	8 #include "build/build_config.h"

	9

	10 namespace offline_pages {

	11

	12 // Any changes to these well-known namespaces should also be reflected in

	13 // OfflinePagesNamespace (histograms.xml) for consistency.

	14 extern const char kBookmarkNamespace[];
	dewittj 2016/05/31 22:38:45 can't this just be constexpr char kBookmarkNamespa can't this just be constexpr char kBookmarkNamespace[] = "foo";? jianli 2016/05/31 23:50:08 Yes, it would work. But we don't really needs thei Show quoted text On 2016/05/31 22:38:45, dewittj wrote: > can't this just be constexpr char kBookmarkNamespace[] = "foo";? Yes, it would work. But we don't really needs their content in header file, right? If so, it is suggested to still put it in .cc file.
	15 extern const char kLastNNamespace[];

	16

	17 // Currently used for fallbacks like tests.

	18 extern const char kDefaultNamespace[];

	19

	20 } // namespace offline_pages

	21

	22 #endif // COMPONENTS_OFFLINE_PAGES_CLIENT_NAMESPACE_CONSTANTS_H_

OLD	NEW