Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: base/android/jni_generator/sample_for_tests.h

Issue 2022283002: Update jni_generator documentation removing GYP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_generator/sample_for_tests.h
diff --git a/base/android/jni_generator/sample_for_tests.h b/base/android/jni_generator/sample_for_tests.h
index 1f34ca5f65d7d56e38a8146594eab3bf905f658a..a9cf7b05e9f9dc824e52df16511dc3e2cca1a44d 100644
--- a/base/android/jni_generator/sample_for_tests.h
+++ b/base/android/jni_generator/sample_for_tests.h
@@ -23,59 +23,6 @@ namespace android {
// documentation in SampleForTests.java
//
// For C++ to access Java methods:
-// - GYP Build must be configured to generate bindings:
-// # ...
-// 'targets': [
-// {
-// # An example target that will rely on JNI:
-// 'target_name': 'foo',
-// 'type': '<(component)',
-// # ... normal sources, defines, deps.
-// # For each jni generated .java -> .h header file in foo_jni_headers
-// # target there will be a single .cc file here that includes it.
-// #
-// # Add deps for JNI:
-// 'conditions': [
-// ['OS == "android"', {
-// 'dependencies': [
-// 'foo_java',
-// 'foo_jni_headers',
-// ],
-// }],
-// ],
-// },
-// ],
-// # ...
-// # Create targets for JNI:
-// 'conditions': [
-// ['OS == "android"', {
-// 'targets': [
-// {
-// 'target_name': 'foo_jni_headers',
-// 'type': 'none',
-// 'sources': [
-// 'java/src/org/chromium/example/jni_generator/SampleForTests.java',
-// ],
-// 'variables': {
-// 'jni_gen_package': 'foo',
-// },
-// 'includes': [ '../../../build/jni_generator.gypi' ],
-// },
-// {
-// 'target_name': 'foo_java',
-// 'type': 'none',
-// 'dependencies': [
-// '../../../base/base.gyp:base',
-// ],
-// 'variables': {
-// 'java_in_dir': 'java',
-// },
-// 'includes': [ '../../../build/java.gypi' ],
-// },
-// ],
-// }],
-// ],
-//
// - GN Build must be configured to generate bindings:
// # Add import at top of file:
// if (is_android) {
« no previous file with comments | « base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698