Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2022283002: Update jni_generator documentation removing GYP. (Closed)

Created:
4 years, 6 months ago by scheib
Modified:
4 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update jni_generator documentation removing GYP. Now that the Android build is migrated to GN, remove documentation instructing developers to update GYP files for JNI. Committed: https://crrev.com/41c9414ec4745b963a8e07da4d5ecb824817c32a Cr-Commit-Position: refs/heads/master@{#396925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -54 lines) Patch
M base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_generator/sample_for_tests.h View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scheib
4 years, 6 months ago (2016-05-31 20:28:02 UTC) #2
nyquist
very lgtm! Sadly it seems like there are several places we still refer to the ...
4 years, 6 months ago (2016-05-31 20:48:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022283002/1
4 years, 6 months ago (2016-05-31 20:51:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 20:59:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 21:01:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41c9414ec4745b963a8e07da4d5ecb824817c32a
Cr-Commit-Position: refs/heads/master@{#396925}

Powered by Google App Engine
This is Rietveld 408576698