Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2022273002: Add logging in DefaultComponentInstaller to help investigate a bug (Closed)

Created:
4 years, 6 months ago by xhwang
Modified:
4 years, 6 months ago
Reviewers:
waffles, Sorin Jianu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging in DefaultComponentInstaller to help investigate a bug Now we know that GetRelativeInstallDir() is called for Widevine CDM but we never see ComponentReady() to be called. Adding logs for all failure cases to see what is going wrong. Another possibility is that FinishRegistration() doesn't have a chance to run before the test starts. In that case we'll see StartRegistration() but won't see FinishRegistration(). BUG=614745 Committed: https://crrev.com/ade0ad062792a4e27ab295638379f419bdf10eff Cr-Commit-Position: refs/heads/master@{#397021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -7 lines) Patch
M components/component_updater/default_component_installer.cc View 5 chunks +40 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
xhwang
More logging. PTAL!
4 years, 6 months ago (2016-05-31 20:19:24 UTC) #3
xhwang
sorin: Could you please take a look since waffles@ is OOO today?
4 years, 6 months ago (2016-05-31 21:10:16 UTC) #5
Sorin Jianu
lgtm Thank you!
4 years, 6 months ago (2016-05-31 23:56:05 UTC) #6
Sorin Jianu
lgtm Thank you!
4 years, 6 months ago (2016-05-31 23:56:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022273002/1
4 years, 6 months ago (2016-05-31 23:57:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 01:52:11 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:53:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ade0ad062792a4e27ab295638379f419bdf10eff
Cr-Commit-Position: refs/heads/master@{#397021}

Powered by Google App Engine
This is Rietveld 408576698