Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2022233002: gn/linux: Add last missing tests to components_unittests. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, please use gerrit instead, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn/linux: Add last missing tests to components_unittests. This seems to just work now. BUG=604060, 522654 TBR=rouslan Committed: https://crrev.com/18d45a5ee99333a05c2100a507dcd1c4be978edd Cr-Commit-Position: refs/heads/master@{#396896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
4 years, 6 months ago (2016-05-31 18:10:34 UTC) #3
brucedawson
That was my observation - this change built fine for me on Windows and Linux ...
4 years, 6 months ago (2016-05-31 18:42:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022233002/1
4 years, 6 months ago (2016-05-31 18:43:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 19:34:08 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:35:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18d45a5ee99333a05c2100a507dcd1c4be978edd
Cr-Commit-Position: refs/heads/master@{#396896}

Powered by Google App Engine
This is Rietveld 408576698