Issue 20222: Revert WebFrameImpl::ComputePageRects() rev 9258 changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20222: Revert WebFrameImpl::ComputePageRects() rev 9258 changes (Closed)

Created:
11 years, 10 months ago by Marshall Greenblatt

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Revert WebFrameImpl::ComputePageRects() (webkit\glue\webframe_impl.cc) implementation to rev 9214. The pages_ member of WebFrameImpl must be set properly or printing will fail. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9652

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	webkit/glue/webframe_impl.cc	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Marshall Greenblatt

Please review. M-A: primary (broken in rev 9258) darin: FYI

11 years, 10 months ago (2009-02-10 17:37:29 UTC) #1

lgtm, I'll fix tomorrow.

Expand Messages | Collapse Messages