Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2022183003: Fix & refactor git cl patch. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix & refactor git cl patch. * Fixes a bug when issue was incorrectly over-written in another branch. Add a test case. * Refactor for better flow. * Update outdated errors on wrong arguments. BUG=616105 R=andybons@chromium.org,sergiyb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M git_cl.py View 2 chunks +25 lines, -24 lines 0 comments Download
M tests/git_cl_test.py View 4 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tandrii(chromium)
4 years, 6 months ago (2016-05-31 16:40:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022183003/1
4 years, 6 months ago (2016-05-31 16:40:15 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 16:43:22 UTC) #5
tandrii(chromium)
PTAL
4 years, 6 months ago (2016-05-31 18:47:31 UTC) #6
Bons
lgtm
4 years, 6 months ago (2016-05-31 19:12:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022183003/1
4 years, 6 months ago (2016-05-31 19:50:16 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:53:52 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300681

Powered by Google App Engine
This is Rietveld 408576698