Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: components/autofill/core/common/form_field_data.h

Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed init value Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/form_field_data.h
diff --git a/components/autofill/core/common/form_field_data.h b/components/autofill/core/common/form_field_data.h
index 5a9bb8a89356c48dba81b25d492b3836333a9d39..9b63b6e086005f940d4d9f5dd404a412ec280687 100644
--- a/components/autofill/core/common/form_field_data.h
+++ b/components/autofill/core/common/form_field_data.h
@@ -29,6 +29,12 @@ struct FormFieldData {
ROLE_ATTRIBUTE_OTHER,
};
+ enum CheckStatus {
vabr (Chromium) 2016/05/31 15:48:25 Please use enum class instead of enum, to get bett
Hwanseung Lee(hs1217.lee) 2016/06/09 15:41:59 if enum class used instead of enum, it is complex
+ CHECK_STATUS_NOT_CHECKABLE,
+ CHECK_STATUS_CHECKABLE_BUT_UNCHECKED,
+ CHECK_STATUS_CHECKED,
+ };
+
FormFieldData();
FormFieldData(const FormFieldData& other);
~FormFieldData();
@@ -53,8 +59,7 @@ struct FormFieldData {
// (base::Pickle used to serialize that as 64 bit).
uint64_t max_length;
bool is_autofilled;
- bool is_checked;
- bool is_checkable;
+ CheckStatus check_status;
bool is_focusable;
bool should_autocomplete;
RoleAttribute role;

Powered by Google App Engine
This is Rietveld 408576698