components/autofill/core/browser/form_structure.cc - Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/form_field_unittest.cc ('k') | components/autofill/core/browser/form_structure_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure.cc

diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc

index 16369662768730d96f6c70c6512de5e57733f53e..485da9cf2ed4968c253fe5d7a7daa6e6768f058f 100644

--- a/components/autofill/core/browser/form_structure.cc

+++ b/components/autofill/core/browser/form_structure.cc

@@ -1145,7 +1145,7 @@ void FormStructure::EncodeFormForUpload(AutofillUploadContents* upload) const {

for (const AutofillField* field : fields_) {

// Don't upload checkable fields.

- if (field->is_checkable)

+ if (IsCheckable(field->check_status))

continue;

const ServerFieldTypeSet& types = field->possible_types();

@@ -1310,7 +1310,7 @@ void FormStructure::IdentifySections(bool has_author_specified_sections) {

}

bool FormStructure::ShouldSkipField(const FormFieldData& field) const {

- return field.is_checkable;

+ return IsCheckable(field.check_status);

}

void FormStructure::ProcessExtractedFields() {