components/autofill/core/browser/form_field.cc - Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_field.cc

Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_metrics_unittest.cc ('k') | components/autofill/core/browser/form_field_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_field.cc

diff --git a/components/autofill/core/browser/form_field.cc b/components/autofill/core/browser/form_field.cc

index b7646c8ca7940ef2957b995fa6dc454ae0c274bc..a63634cca723028b83e1a8b2974cf182b46f213c 100644

--- a/components/autofill/core/browser/form_field.cc

+++ b/components/autofill/core/browser/form_field.cc

@@ -34,7 +34,7 @@ bool ShouldBeProcessed(const AutofillField* field) {

// interferes with correctly understanding ADDRESS_LINE2.

// Ignore fields marked as presentational. See

// http://www.w3.org/TR/wai-aria/roles#presentation

- return !(field->is_checkable ||

+ return !(IsCheckable(field->check_status) ||

field->role == FormFieldData::ROLE_ATTRIBUTE_PRESENTATION);

}