Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2022073002: [turbofan] ARM64: Match 64 bit compare with zero and branch (Closed)

Created:
4 years, 6 months ago by Pierre Langlois
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM64: Match 64 bit compare with zero and branch This patch enables the following transformations in the instruction selector: | Before | After | |------------------+------------------------| | and x3, x1, #0x1 | tb{,n}z w1, #0, #+0x78 | | cmp x3, #0x0 | | | b.{eq,ne} #+0x80 | | |------------------+------------------------| | cmp x0, #0x0 | cb{,n}z x0, #+0x48 | | b.{eq,ne} #+0x4c | | I have not seen these patterns beeing generated by turbofan, however the stubs hit these cases frequently. A particular reason is that we are turning operations that check for a Smi into a single `tbz`. As a concequence, the interpreter is affected thanks to inlining turbofan stubs into it's bytecode handlers. I have noticed the size of the interpreter was reduced by 200 instructions. BUG= Committed: https://crrev.com/27bd1747b493d02d9bcd8499c51b2d1022838ced Cr-Commit-Position: refs/heads/master@{#36632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -31 lines) Patch
M src/base/bits.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-scheduler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 4 chunks +49 lines, -29 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 3 chunks +154 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Pierre Langlois
4 years, 6 months ago (2016-05-31 13:23:09 UTC) #3
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-01 04:14:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022073002/1
4 years, 6 months ago (2016-06-01 07:32:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 08:01:10 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 08:03:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27bd1747b493d02d9bcd8499c51b2d1022838ced
Cr-Commit-Position: refs/heads/master@{#36632}

Powered by Google App Engine
This is Rietveld 408576698