Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 202203009: Rename |imp| => |impl| in bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: custom/v8 too Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index 50123e987cad1a9b1847b004c87a38622a1240a6..29f777c6c97d9cbab50d97eb8be7a6400f53b7af 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -81,9 +81,9 @@ static void itemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
exceptionState.throwIfNeeded();
return;
}
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
V8TRYCATCH_EXCEPTION_VOID(unsigned, index, toUInt32(info[0], exceptionState), exceptionState);
- v8SetReturnValue(info, imp->item(index));
+ v8SetReturnValue(info, impl->item(index));
}
static void itemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -99,9 +99,9 @@ static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
throwTypeError(ExceptionMessages::failedToExecute("namedItem", "TestEventTarget", ExceptionMessages::notEnoughArguments(1, info.Length())), info.GetIsolate());
return;
}
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, name, info[0]);
- v8SetReturnValue(info, imp->namedItem(name));
+ v8SetReturnValue(info, impl->namedItem(name));
}
static void namedItemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -113,11 +113,11 @@ static void namedItemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& i
static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
- RefPtr<Node> result = imp->item(index);
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
+ RefPtr<Node> result = impl->item(index);
if (!result)
return;
- v8SetReturnValueFast(info, WTF::getPtr(result.release()), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), impl);
}
static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -129,14 +129,14 @@ static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCall
static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
V8TRYCATCH_VOID(Node*, propertyValue, V8Node::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
if (!isUndefinedOrNull(jsValue) && !V8Node::hasInstance(jsValue, info.GetIsolate())) {
exceptionState.throwTypeError("The provided value is not of type 'Node'.");
exceptionState.throwIfNeeded();
return;
}
- bool result = imp->anonymousIndexedSetter(index, propertyValue);
+ bool result = impl->anonymousIndexedSetter(index, propertyValue);
if (!result)
return;
v8SetReturnValue(info, jsValue);
@@ -151,9 +151,9 @@ static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> j
static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
ExceptionState exceptionState(ExceptionState::IndexedDeletionContext, "TestEventTarget", info.Holder(), info.GetIsolate());
- DeleteResult result = imp->anonymousIndexedDeleter(index, exceptionState);
+ DeleteResult result = impl->anonymousIndexedDeleter(index, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (result != DeleteUnknownProperty)
@@ -174,12 +174,12 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
return;
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
- RefPtr<Node> result = imp->namedItem(propertyName);
+ RefPtr<Node> result = impl->namedItem(propertyName);
if (!result)
return;
- v8SetReturnValueFast(info, WTF::getPtr(result.release()), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), impl);
}
static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -196,10 +196,10 @@ static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value>
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
return;
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyName, name);
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyValue, jsValue);
- bool result = imp->anonymousNamedSetter(propertyName, propertyValue);
+ bool result = impl->anonymousNamedSetter(propertyName, propertyValue);
if (!result)
return;
v8SetReturnValue(info, jsValue);
@@ -214,11 +214,11 @@ static void namedPropertySetterCallback(v8::Local<v8::String> name, v8::Local<v8
static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
v8::String::Utf8Value namedProperty(name);
ExceptionState exceptionState(ExceptionState::GetterContext, *namedProperty, "TestEventTarget", info.Holder(), info.GetIsolate());
- bool result = imp->namedPropertyQuery(propertyName, exceptionState);
+ bool result = impl->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (!result)
@@ -235,9 +235,9 @@ static void namedPropertyQueryCallback(v8::Local<v8::String> name, const v8::Pro
static void namedPropertyDeleter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
- DeleteResult result = imp->anonymousNamedDeleter(propertyName);
+ DeleteResult result = impl->anonymousNamedDeleter(propertyName);
if (result != DeleteUnknownProperty)
return v8SetReturnValueBool(info, result == DeleteSuccess);
}
@@ -251,10 +251,10 @@ static void namedPropertyDeleterCallback(v8::Local<v8::String> name, const v8::P
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- TestEventTarget* imp = V8TestEventTarget::toNative(info.Holder());
+ TestEventTarget* impl = V8TestEventTarget::toNative(info.Holder());
Vector<String> names;
ExceptionState exceptionState(ExceptionState::EnumerationContext, "TestEventTarget", info.Holder(), info.GetIsolate());
- imp->namedPropertyEnumerator(names, exceptionState);
+ impl->namedPropertyEnumerator(names, exceptionState);
if (exceptionState.throwIfNeeded())
return;
v8::Handle<v8::Array> v8names = v8::Array::New(info.GetIsolate(), names.size());
« no previous file with comments | « Source/bindings/tests/results/V8SVGTestInterface.cpp ('k') | Source/bindings/tests/results/V8TestException.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698