Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2022023002: Reland: Forward output glitch information from stream WebRTC log (Closed)

Created:
4 years, 6 months ago by Henrik Grunell
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mcasas+watch+vc_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, lcwu+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward output glitch information from stream WebRTC log * A callback is added as input parameter on AudioManager create stream functions. * OnLogMessage() function is added to the AudioLog interface. * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream. * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog(). * In both input and output cases, the message is then passed to the WebRTC log. * The Mac input and output streams inform about OS glitches via the callback. This relands https://codereview.chromium.org/1864483002 BUG=610967 TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged files from original CL) Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d Cr-Commit-Position: refs/heads/master@{#396818}

Patch Set 1 : Original CL #

Patch Set 2 : Fixed two unit tests. Added DCHECKs. #

Patch Set 3 : Added missing include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -210 lines) Patch
M chromecast/media/audio/cast_audio_manager.h View 1 chunk +8 lines, -4 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/audio_modem/audio_recorder_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/media/media_internals.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/alsa/alsa_output_unittest.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M media/audio/alsa/audio_manager_alsa.h View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/alsa/audio_manager_alsa.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M media/audio/android/audio_android_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/audio/android/audio_manager_android.h View 1 chunk +14 lines, -7 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 5 chunks +19 lines, -10 lines 0 comments Download
M media/audio/audio_input_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/audio/audio_input_controller.cc View 11 chunks +20 lines, -14 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M media/audio/audio_logging.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 2 4 chunks +7 lines, -2 lines 0 comments Download
M media/audio/audio_manager.h View 4 chunks +9 lines, -2 lines 0 comments Download
M media/audio/audio_manager_base.h View 2 chunks +16 lines, -7 lines 0 comments Download
M media/audio/audio_manager_base.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 20 chunks +52 lines, -37 lines 0 comments Download
M media/audio/cras/audio_manager_cras.h View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/cras/audio_manager_cras.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M media/audio/fake_audio_log_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/fake_audio_manager.h View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/fake_audio_manager.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.h View 3 chunks +6 lines, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 1 4 chunks +13 lines, -6 lines 0 comments Download
M media/audio/mac/audio_auhal_mac_unittest.cc View 4 chunks +19 lines, -5 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 3 chunks +6 lines, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 1 5 chunks +15 lines, -7 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 4 chunks +11 lines, -2 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 5 chunks +14 lines, -7 lines 0 comments Download
M media/audio/mock_audio_manager.h View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.h View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +8 lines, -4 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 13 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Henrik Grunell
4 years, 6 months ago (2016-05-31 10:15:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022023002/40001
4 years, 6 months ago (2016-05-31 10:15:25 UTC) #6
tommi (sloooow) - chröme
lgtm
4 years, 6 months ago (2016-05-31 10:18:29 UTC) #7
Henrik Grunell
I'm TBR'ing for a few unchanged files from original CL. sievers: content/browser/* slan: chromecast/* xiyuan: ...
4 years, 6 months ago (2016-05-31 10:25:36 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/145323)
4 years, 6 months ago (2016-05-31 10:28:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022023002/60001
4 years, 6 months ago (2016-05-31 10:33:58 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-05-31 12:45:52 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d Cr-Commit-Position: refs/heads/master@{#396818}
4 years, 6 months ago (2016-05-31 12:46:58 UTC) #19
Guido Urdaneta
4 years, 6 months ago (2016-06-01 12:51:37 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2028053002/ by guidou@chromium.org.

The reason for reverting is: This is a speculative revert, as this CL is suspect
of breaking the WebRTC Linux Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland..

Powered by Google App Engine
This is Rietveld 408576698