Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2022013002: binding: Makes [SaveSameObject] use V8PrivateProperty. (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes [SaveSameObject] use V8PrivateProperty. Migrates from V8HiddenValue to V8PrivateProperty in [SaveSameObject] implementation. BUG= Committed: https://crrev.com/29d1fbe672ebcb1f6332f4109240e200e095b386 Cr-Commit-Position: refs/heads/master@{#396815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Could you review this CL?
4 years, 6 months ago (2016-05-31 07:37:16 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-05-31 08:23:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022013002/1
4 years, 6 months ago (2016-05-31 09:53:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 11:23:38 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 11:25:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/29d1fbe672ebcb1f6332f4109240e200e095b386
Cr-Commit-Position: refs/heads/master@{#396815}

Powered by Google App Engine
This is Rietveld 408576698