Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6454)

Unified Diff: chrome/browser/resources/md_history/synced_device_card.js

Issue 2022003002: [MD History] Add search for synced devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@land_icons
Patch Set: address nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/synced_device_card.js
diff --git a/chrome/browser/resources/md_history/synced_device_card.js b/chrome/browser/resources/md_history/synced_device_card.js
index 4b01791c3551e8b0f16a840a60dd3ba4272f559b..44211705e9446de16c1469938f512e44470a057b 100644
--- a/chrome/browser/resources/md_history/synced_device_card.js
+++ b/chrome/browser/resources/md_history/synced_device_card.js
@@ -28,6 +28,14 @@ Polymer({
observer: 'updateIcons_'
},
+ /**
+ * The indexes where a window separator should be shown. The use of a
+ * separate array here is necessary for window separators to appear
+ * correctly in search. See http://crrev.com/2022003002 for more details.
+ * @type {!Array<number>}
+ */
+ separatorIndexes: Array,
+
// Whether the card is open.
cardOpen_: {
type: Boolean,
@@ -68,5 +76,9 @@ Polymer({
cr.icon.getFaviconImageSet(this.tabs[i].url);
}
});
+ },
+
+ isWindowSeparatorIndex_: function(index, separatorIndexes) {
tsergeant 2016/06/03 00:56:17 Follow up nit since you need to rebase anyway: /*
+ return this.separatorIndexes.indexOf(index) != -1;
}
});

Powered by Google App Engine
This is Rietveld 408576698