src/utils/SkPDFRasterizer.h - Issue 20220002: Add libpoppler PDF rasterizer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/utils/SkPDFRasterizer.h

Issue 20220002: Add libpoppler PDF rasterizer (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Make rasterizer header internal Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2013 Google Inc.
	vandebo (ex-Chrome) 2013/08/01 17:49:51 Should this file be name SkPDFPopplerRasterizer.h Should this file be name SkPDFPopplerRasterizer.h ? ducky 2013/08/01 20:40:23 I actually intended this to be for rasterizing PDF Show quoted text On 2013/08/01 17:49:51, vandebo wrote: > Should this file be name SkPDFPopplerRasterizer.h ? I actually intended this to be for rasterizing PDF files in general, where interfaces for multiple backends could live (even though we only use poppler currently)
	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7 #ifndef SkPDFRasterizer_DEFINED

	8 #define SkPDFRasterizer_DEFINED

	9

	10 #include "SkBitmap.h"

	11 #include "SkStream.h"

	12

	13 bool SkPopplerRasterizePDF(SkStream* pdf, SkBitmap* output);
	vandebo (ex-Chrome) 2013/08/01 17:49:51 Should it take a page number as an argument? Should it take a page number as an argument? ducky 2013/08/01 20:40:23 The problem with that then becomes that the caller Show quoted text On 2013/08/01 17:49:51, vandebo wrote: > Should it take a page number as an argument? The problem with that then becomes that the caller to this function doesn't know how many pages there are total, so actually using the page argument becomes a bit difficult. This was also based off the Mac renderer interface, which had a hardcoded page 1 as well. It also makes sense to rasterize a whole document, since for testing purposes, we're concerned about whole-document accuracy. Though since (I think) no GMs actually outputs multi-page PDFs, I don't think that code has been necessary so far.
	14

	15 #endif

OLD	NEW

« gyp/poppler.gyp ('K') | « gyp/poppler.gyp ('k') | src/utils/SkPDFRasterizer.cpp » ('j') | third_party/fontconfig/linux/config.h » ('J')