Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/utils/SkPDFRasterizer.cpp

Issue 20220002: Add libpoppler PDF rasterizer (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: 80 cols Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1
2 /*
3 * Copyright 2013 Google Inc.
4 *
5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file.
7 */
8
9 #ifdef SK_BUILD_FOR_WIN32
10 #pragma warning(push)
vandebo (ex-Chrome) 2013/08/14 15:41:37 Don't indent these.
ducky 2013/08/14 20:43:18 Done.
11 #pragma warning(disable : 4530)
12 #endif
13
14 #include <poppler-document.h>
15 #include <poppler-image.h>
16 #include <poppler-page.h>
17 #include <poppler-page-renderer.h>
18
19 #include "SkPDFRasterizer.h"
20 #include "SkColorPriv.h"
21
22 bool SkPopplerRasterizePDF(SkStream* pdf, SkBitmap* output) {
23 size_t size = pdf->getLength();
24 void* buffer = sk_malloc_throw(size);
25 pdf->read(buffer, size);
26
27 SkAutoTDelete<poppler::document> doc(
28 poppler::document::load_from_raw_data((const char*)buffer, size));
29 if (!doc.get() || doc->is_locked()) {
30 return false;
31 }
32
33 SkAutoTDelete<poppler::page> page(doc->create_page(0));
34 poppler::page_renderer renderer;
35 poppler::image image = renderer.render_page(page.get());
36
37 if (!image.is_valid() || image.format() != poppler::image::format_argb32) {
38 return false;
39 }
40
41 size_t width = image.width(), height = image.height();
42 size_t rowSize = image.bytes_per_row();
43 char *imgData = image.data();
44
45 SkBitmap bitmap;
46 bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, height);
47 if (!bitmap.allocPixels()) {
48 return false;
49 }
50 bitmap.eraseColor(SK_ColorWHITE);
51 SkPMColor* bitmapPixels = (SkPMColor*)bitmap.getPixels();
52
53 // do pixel-by-pixel copy to deal with RGBA ordering conversions
54 for (size_t y = 0; y < height; y++) {
55 char *rowData = imgData;
56 for (size_t x = 0; x < width; x++) {
57 U8CPU r = (unsigned char)rowData[2];
58 U8CPU g = (unsigned char)rowData[1];
59 U8CPU b = (unsigned char)rowData[0];
60
61 SkPMColor out = SkPackARGB32(
62 255, r, g, b);
vandebo (ex-Chrome) 2013/08/14 15:41:37 Are you dropping the alpha component?
vandebo (ex-Chrome) 2013/08/14 15:41:37 nit: line wrap.
ducky 2013/08/14 20:43:18 Done.
ducky 2013/08/14 20:43:18 Yes. I tried adding back in the alpha, but the pic
vandebo (ex-Chrome) 2013/08/15 00:22:13 This concerns me. Can you try using this with a p
ducky 2013/08/15 01:19:12 Looks like I typo'd when unpacking my pixels... Sk
63
64 *bitmapPixels = out;
65
66 bitmapPixels++;
67 rowData += 4;
68 }
69 imgData += rowSize;
70 }
71
72 output->swap(bitmap);
73
74 return true;
75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698