Add libpoppler PDF rasterizer

third_party/iconv/README.chromium

+Name: libiconv
+Short Name: libiconv
+URL: git://git.savannah.gnu.org/libiconv.git
+Version: v1.14 (upstream Git repo tag)
+License: Libraries under LGPL, program under GPL

[Lei Zhang, 2013/08/08 21:47:56]

Are you even checking out / building the "program" portion?

[ducky, 2013/08/09 22:14:57]

The program portion should not be built. But I think it's included in the
repository that gets checked out.

+License File: LICENSE / NOT_SHIPPED

[Lei Zhang, 2013/08/08 21:47:56]

This should just say NOT_SHIPPED.

[ducky, 2013/08/09 22:14:57]

Done.

+Security Critical: No
+
+Description:
+Dependency of libpoppler

[Lei Zhang, 2013/08/08 21:47:56]

Put in a real description of what libiconv is. It's clearly an icon vector
library, right?

[ducky, 2013/08/09 22:14:57]

Done.
Depends on how much character encodings are related to vector icons - I'm sure
text characters can be described as vector icons...

+
+Local Modifications:
+No changes to files from the upstream repository.
+Platform-specific configuration files added to third_party/iconv/config/(platform):

[Lei Zhang, 2013/08/08 21:47:56]

Please try to observe the 80 col rule here too.

[Lei Zhang, 2013/08/08 21:47:56]

s/(platform)/windows/

[ducky, 2013/08/09 22:14:57]

???

[ducky, 2013/08/09 22:14:57]

Done

[Lei Zhang, 2013/08/09 22:26:48]

As in:

Platform-specific configuration files added to third_party/iconv/config/windows/

[ducky, 2013/08/12 22:05:10]

Done.

+  config.h
+  iconv.h
+  localcharset.h
+
+These files were created from the header templates based on instructions from http://www.codeproject.com/Articles/302012/How-to-Build-libiconv-with-Microsoft-Visual-Studio, then kludging it to build. The minimalistic version used here for a static build is:
+1. Download the libiconv-1.14 tarball from http://www.gnu.org/software/libiconv/#downloading
+2. Copy and rename these files:
+    (libiconv-1.14)/libcharset/include/localcharset.h.build.in
+      -> third_party/iconv/config/windows/localcharset.h
+    (libiconv-1.14)/include/iconv.h.build.in
+      -> third_party/iconv/config/windows/iconv.h
+    (libiconv-1.14)/config.h.in
+      -> third_party/iconv/config/windows/config.h
+3. Modify localcharset.h as follows:

[Lei Zhang, 2013/08/08 21:47:56]

You may want to just include a .patch file and say "apply foo.patch".

[ducky, 2013/08/09 22:14:57]

The files are pre-included, the instructions are only if people want to repeat
the process for a later version. That should be a bit more clear now.

+    Replace
+      #if @HAVE_VISIBILITY@ && BUILDING_LIBCHARSET
+      #define LIBCHARSET_DLL_EXPORTED __attribute__((__visibility__("default")))
+      #else
+      #define LIBCHARSET_DLL_EXPORTED
+      #endif
+    with
+      #define LIBCHARSET_DLL_EXPORTED
+4. Modify config.h as follows:
+    Delete line 30:
+      #undef EILSEQ
+    Change line 686 to:
+      #define ICONV_CONST const
+5. Modify iconv.h as follows:
+    Replace
+      #if @HAVE_VISIBILITY@ && BUILDING_LIBICONV
+      #define LIBICONV_DLL_EXPORTED __attribute__((__visibility__("default")))
+      #else
+      #define LIBICONV_DLL_EXPORTED
+      #endif
+    with
+      #define LIBICONV_DLL_EXPORTED 
+    Delete all references to @DLL_VARIABLE@ (find and replace with nothing).
+    Find and replace these:
+      @ICONV_CONST@ -> const
+      @USE_MBSTATE_T@ -> USE_MBSTATE_T
+      @BROKEN_WCHAR_H@ -> BROKEN_WCHAR_H
+      @HAVE_WCHAR_T@ -> HAVE_WCHAR_T
+Note: if a dynamic library is needed for whatever reason, LIBCHARSET_DLL_EXPORTED and LIBICONV_DLL_EXPORTED needs to be defined as either __declspec(dllexport) or __declspec(dllimport).
+
+Autogenerated files (consistent across platforms) added to third_party/iconv/config:
+  aliases.h
+  canonical_dos.h
+  canonical.h
+  canonical_local.h
+  flags.h
+
+These files were pulled from a release tarball.

[Lei Zhang, 2013/08/08 21:47:56]

Put this closer to line 59. At first I thought you had to run some tool to
auto-generate them, then I realized where they actually came from.

Mention the release version of the tarball.