Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2021983002: Get rid of an unused parameter in FrameSelection::moveTo() (Closed)

Created:
4 years, 8 months ago by yosin_UTC9
Modified:
4 years, 2 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of an unused parameter in FrameSelection::moveTo() This patch gets rid of unused parameter in |Position| version of |FrameSelection::moveTo()| to simplify code for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/183224394171341228ca0dcbe522b2dc80776995 Cr-Commit-Position: refs/heads/master@{#396784}

Patch Set 1 : 2016-05-31T10:00:26 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yosin_UTC9
PTAL
4 years, 8 months ago (2016-05-31 01:37:32 UTC) #3
yoichio
lgtm
4 years, 8 months ago (2016-05-31 01:53:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021983002/1
4 years, 8 months ago (2016-05-31 01:54:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78828)
4 years, 8 months ago (2016-05-31 02:54:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021983002/1
4 years, 8 months ago (2016-05-31 03:54:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-05-31 04:40:27 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-05-31 04:41:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/183224394171341228ca0dcbe522b2dc80776995
Cr-Commit-Position: refs/heads/master@{#396784}

Powered by Google App Engine
This is Rietveld 408576698