Make click targets inside links work.

Make click targets inside links work.

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG=615904
R=dmazzoni@chromium.org

Committed: https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e
Cr-Commit-Position: refs/heads/master@{#397211}

[dmazzoni, 2016-05-31 17:16:55]

Can you add a test for it? I think you could use the first test in
LayoutTests/accessibility/click-event.html as a template.

[nektarios, 2016-05-31 21:34:31]

Test added using the template you pointed out.
However, I have difficulty making the drag and gesture test cases work. It might
be because the amount that the mouse needs to move is different in this case?

[dmazzoni, 2016-05-31 21:58:08]

I think you're testing the opposite of what you want to be testing.

The bug says that when the user does an accessible click, the ordinary event
handler gets called.

Your test is testing that when the user does a normal click (with the mouse or
with a javascript click), the accessible event notification happens. That's not
the same thing.

I think your test should click on the accessible element, not the DOM element -
and then it should succeed if the DOM event handler gets called, not if the
accessible event notification is fired.

[blink-reviews, 2016-05-31 22:26:14]

I didn't want to test only what the bug said because there might have 
been other bugs hiding in similar code paths that I didn't know about. 
But I agree that for the test case concerning accessibility press, I 
should test both for the DOM event and the accessibility event.
I uploaded a new patch.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-05-31 22:26:15]

I didn't want to test only what the bug said because there might have 
been other bugs hiding in similar code paths that I didn't know about. 
But I agree that for the test case concerning accessibility press, I 
should test both for the DOM event and the accessibility event.
I uploaded a new patch.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-06-01 17:22:31]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-06-01 17:22:32]

lgtm

[commit-bot: I haz the power, 2016-06-01 17:22:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021953002/60001

[commit-bot: I haz the power, 2016-06-01 19:46:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 19:47:25]

Description was changed from

==========
Make click targets inside links work.

There are pages that attach click handlers to elements that are found inside
links, and screen readers might try to click such elements. Our existing
doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might
invoke the default action on the graphic.
BUG=615904
R=dmazzoni@chromium.org
==========

to

==========
Make click targets inside links work.

There are pages that attach click handlers to elements that are found inside
links, and screen readers might try to click such elements. Our existing
doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might
invoke the default action on the graphic.
BUG=615904
R=dmazzoni@chromium.org

Committed: https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e
Cr-Commit-Position: refs/heads/master@{#397211}
==========

[commit-bot: I haz the power, 2016-06-01 19:47:31]

Patchset 4 (id:??) landed as
https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e
Cr-Commit-Position: refs/heads/master@{#397211}

[jbroman, 2016-06-02 15:34:36]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2035583003/ by jbroman@chromium.org.

The reason for reverting is: Flakily timing out:
https://bugs.chromium.org/p/chromium/issues/detail?id=616768.

[nektarios, 2016-06-03 16:09:23]

I fixed the flaky test.

[dmazzoni, 2016-06-03 16:12:20]

lgtm, but please create a new issue, then feel free to TBR me and commit. Run
"git cl issue 0" to remove the issue number and upload again to a new issue.