Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: src/heap/spaces.h

Issue 2021893002: Revert of Reland "[heap] Fine-grained JSArrayBuffer tracking" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/scavenger.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index f9b473d0de854520950cff14ef6fc49571d30adc..59d8cfb6d9ed6d9d7c06d8e9d58689cb2950437e 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -14,7 +14,6 @@
#include "src/base/platform/mutex.h"
#include "src/flags.h"
#include "src/hashmap.h"
-#include "src/heap/array-buffer-tracker.h"
#include "src/list.h"
#include "src/objects.h"
#include "src/utils.h"
@@ -469,8 +468,6 @@
kSweepingInProgress,
};
- enum ArrayBufferTrackerAccessMode { kDontCreate, kCreateIfNotPresent };
-
// Every n write barrier invocations we go to runtime even though
// we could have handled it in generated code. This lets us check
// whether we have hit the limit and should do some more marking.
@@ -526,8 +523,7 @@
+ kPointerSize // AtomicValue next_chunk_
+ kPointerSize // AtomicValue prev_chunk_
// FreeListCategory categories_[kNumberOfCategories]
- + FreeListCategory::kSize * kNumberOfCategories +
- kPointerSize; // LocalArrayBufferTracker tracker_
+ + FreeListCategory::kSize * kNumberOfCategories;
// We add some more space to the computed header size to amount for missing
// alignment requirements in our computation.
@@ -646,21 +642,6 @@
void AllocateTypedOldToOldSlots();
void ReleaseTypedOldToOldSlots();
- template <ArrayBufferTrackerAccessMode tracker_access>
- inline LocalArrayBufferTracker* local_tracker() {
- LocalArrayBufferTracker* tracker = local_tracker_.Value();
- if (tracker == nullptr && tracker_access == kCreateIfNotPresent) {
- tracker = new LocalArrayBufferTracker(heap_);
- if (!local_tracker_.TrySetValue(nullptr, tracker)) {
- tracker = local_tracker_.Value();
- }
- DCHECK_NOT_NULL(tracker);
- }
- return tracker;
- }
-
- void ReleaseLocalTracker();
-
Address area_start() { return area_start_; }
Address area_end() { return area_end_; }
int area_size() { return static_cast<int>(area_end() - area_start()); }
@@ -842,8 +823,6 @@
base::AtomicValue<MemoryChunk*> prev_chunk_;
FreeListCategory categories_[kNumberOfCategories];
-
- base::AtomicValue<LocalArrayBufferTracker*> local_tracker_;
private:
void InitializeReservedMemory() { reservation_.Reset(); }
@@ -2321,16 +2300,6 @@
inline void UnlinkFreeListCategories(Page* page);
inline intptr_t RelinkFreeListCategories(Page* page);
- // Callback signature:
- // void Callback(Page*);
- template <typename Callback>
- void ForAllPages(Callback callback) {
- PageIterator it(this);
- while (it.has_next()) {
- callback(it.next());
- }
- }
-
protected:
// PagedSpaces that should be included in snapshots have different, i.e.,
// smaller, initial pages.
« no previous file with comments | « src/heap/scavenger.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698