Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2021893002: Revert of Reland "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "[heap] Fine-grained JSArrayBuffer tracking" (patchset #3 id:60001 of https://codereview.chromium.org/2026463002/ ) Reason for revert: Investigating new arm simulator failure: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim/builds/851/steps/Check%20-%20novfp3/logs/box2d Original issue's description: > Reland "[heap] Fine-grained JSArrayBuffer tracking" > > Track based on JSArrayBuffer addresses on pages instead of the attached > backing store. > > Details of tracking: > - Scavenge: New space pages are processes in bulk on the main thread > - MC: Unswept pages are processed in bulk in parallel. All other pages > are processed by the sweeper concurrently. > > BUG=chromium:614730, chromium:611688 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/bc0fb6e83eb7351f52bfd6f780bb6c12bd87c58c > Cr-Commit-Position: refs/heads/master@{#36592} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:614730, chromium:611688 Committed: https://crrev.com/ecb2ec8ff30289c59804afdd5359f3634e1c8921 Cr-Commit-Position: refs/heads/master@{#36593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -621 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 2 chunks +41 lines, -91 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 1 chunk +93 lines, -139 lines 0 comments Download
D src/heap/array-buffer-tracker-inl.h View 1 chunk +0 lines, -87 lines 0 comments Download
M src/heap/heap.h View 4 chunks +6 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +11 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +18 lines, -16 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/heap/scavenger.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +1 line, -32 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +1 line, -10 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +0 lines, -206 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Lippautz
Created Revert of Reland "[heap] Fine-grained JSArrayBuffer tracking"
4 years, 6 months ago (2016-05-30 15:48:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021893002/1
4 years, 6 months ago (2016-05-30 15:48:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 15:48:36 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 15:50:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecb2ec8ff30289c59804afdd5359f3634e1c8921
Cr-Commit-Position: refs/heads/master@{#36593}

Powered by Google App Engine
This is Rietveld 408576698