content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc - Issue 202183003: Fixing race conditions in ui::content::WindowSlider which could cause the overscroll overlay to nev…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

Issue 202183003: Fixing race conditions in ui::content::WindowSlider which could cause the overscroll overlay to nev… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implementing some of the review feedback. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/aura/overscroll_navigation_overlay.cc ('k') | content/browser/web_contents/aura/window_slider.h » ('j') | content/browser/web_contents/aura/window_slider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

index f19d61eead03593e93c5b509715b8e7407dc0a0e..38d0d8c3307adb8483645512ac3e05e80e06b44b 100644

--- a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

@@ -50,10 +50,11 @@ class OverscrollNavigationOverlayTest : public RenderViewHostImplTestHarness {

void PerformBackNavigationViaSliderCallbacks() {

// Sets slide direction to SLIDE_BACK, sets screenshot from NavEntry at

// offset -1 on layer_delegate_.

- delete GetOverlay()->CreateBackLayer();

+ delete GetOverlay()->OnSlideBackStartedCreateLayer();

// Performs BACK navigation, sets image from layer_delegate_ on

// image_delegate_.

- GetOverlay()->OnWindowSlideComplete();

+ GetOverlay()->OnWindowSlideCompleting();

+ GetOverlay()->OnWindowSlideCompleted();

}

protected: