Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2897)

Issue 2021773004: Restore PendingScript prefinalizer. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore PendingScript prefinalizer. Under some as yet unknown conditions, PendingScript objects can become garbage without having been explicitly detached/disposed of first. Hence restore the prefinalizer that r396656 removed. R= BUG=615977 Committed: https://crrev.com/0c49fbd993f6e61520554e115a3bf04ba9d2d4f8 Cr-Commit-Position: refs/heads/master@{#396813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-05-31 09:24:22 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-05-31 09:31:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021773004/1
4 years, 6 months ago (2016-05-31 09:34:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 10:58:27 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 11:00:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c49fbd993f6e61520554e115a3bf04ba9d2d4f8
Cr-Commit-Position: refs/heads/master@{#396813}

Powered by Google App Engine
This is Rietveld 408576698