Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2021753002: Change gae to apache 2 license. (Closed)

Created:
4 years, 6 months ago by estaab
Modified:
4 years, 6 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Change gae to apache 2 license. Update AUTHORS, CONTRIBUTORS, and LICENSE. Add apache 2 license check to PRESUBMIT.py. Ran: git sed 's/Chromium Authors/LUCI Authors/' git sed 's/governed by a BSD-style license that can be/governed under the Apache License, Version 2.0/' git sed 's/found in the LICENSE file/that can be found in the LICENSE file/' git checkout HEAD -- $(git status -sb | grep '^ T' | cut -c 4-) git checkout origin/master -- $(git diff origin/master --name-only | grep third_party) BUG= Committed: https://github.com/luci/gae/commit/ba34d4de4e197ec8cc420faea99caee59eb7205e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+772 lines, -546 lines) Patch
M .travis.yml View 1 chunk +3 lines, -3 lines 0 comments Download
A AUTHORS View 1 chunk +12 lines, -0 lines 0 comments Download
A CONTRIBUTORS View 1 chunk +39 lines, -0 lines 0 comments Download
M LICENSE View 1 chunk +202 lines, -27 lines 0 comments Download
M PRESUBMIT.py View 2 chunks +8 lines, -8 lines 0 comments Download
M doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/count.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/count_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/gi.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/mail.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/mc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/mod.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/rds.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/tq.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/count/user.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dsQueryBatch/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dsQueryBatch/filter.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dsQueryBatch/filter_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/ds.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/ds_txn.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/ds_txn_state.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/dscache.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/dscache_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/globalconfig.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/plan.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/serialize.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/dscache/support.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/featurebreaker.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/featurebreaker_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/gi.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/mail.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/mc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/mod.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/rds.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/tq.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/featureBreaker/user.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/ds.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/ds_txn.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/query_merger.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/race_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/state.go View 1 chunk +3 lines, -3 lines 0 comments Download
M filter/txnBuf/txnbuf_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/dummy/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/dummy/dummy.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/dummy/dummy_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_data.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_index.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_index_selection.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_index_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_query.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_query_execution.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_query_execution_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_query_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/error_markers.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/gkvlite_iter.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/gkvlite_iter_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/gkvlite_tracing_utils.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/gkvlite_utils.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/gkvlite_utils_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/info.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/info_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/mail.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/mail_static_lists.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/mail_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/memcache.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/memcache_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/module.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/module_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/race_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/taskqueue.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/taskqueue_data.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/taskqueue_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/testing_utils_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/user.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/memory/user_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/context_vm.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/datastore_key.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/everything_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/info.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/logger.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/mail.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/memcache.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/module.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/raw_datastore.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/raw_datastore_type_converter.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/taskqueue.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/urlfetch.go View 1 chunk +3 lines, -3 lines 0 comments Download
M impl/prod/user.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/blobstore/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/blobstore/types.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/checkfilter.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/checkfilter_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/context_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/datastore.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/datastore_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/errors.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/finalized_query.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/index.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/index_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/key.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/key_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/meta/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/meta/eg.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/meta/eg_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/meta/namespaces.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/meta/namespaces_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/multiarg.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/pls.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/pls_impl.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/pls_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/properties.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/properties_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/query.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/query_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/raw_interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/raw_interface_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/reflect.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/binary_tools.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/binary_tools_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/doc.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/invertible.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/invertible_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/serialize.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/serialize_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/size_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/testable.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/types.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/types_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/info/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/info/interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/info/types.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/logging/logging.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/mail/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/mail/interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/mail/message.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/mail/message_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/mail/testable.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/memcache/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/memcache/errors.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/memcache/interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/memcache/memcache.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/memcache/raw_interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/memcache/types.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/module/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/module/interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/errors.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/raw_interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/task.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/taskqueue.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/testable.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/taskqueue/types.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/urlfetch/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/user/context.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/user/interface.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/user/testable.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/user/user.go View 1 chunk +3 lines, -3 lines 0 comments Download
M symbols.go View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/proto-gae/proto_gae.go View 3 chunks +7 lines, -7 lines 1 comment Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021753002/1
4 years, 6 months ago (2016-05-30 01:01:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-30 01:05:52 UTC) #4
estaab
4 years, 6 months ago (2016-05-30 17:46:08 UTC) #7
M-A Ruel
lgtm https://codereview.chromium.org/2021753002/diff/1/tools/proto-gae/proto_gae.go File tools/proto-gae/proto_gae.go (right): https://codereview.chromium.org/2021753002/diff/1/tools/proto-gae/proto_gae.go#newcode44 tools/proto-gae/proto_gae.go:44: const copyright = `// Copyright 2016 The LUCI ...
4 years, 6 months ago (2016-05-30 18:28:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021753002/1
4 years, 6 months ago (2016-05-31 21:58:36 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 22:04:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/ba34d4de4e197ec8cc420faea99caee59eb7205e

Powered by Google App Engine
This is Rietveld 408576698