Move _baseline_name to test_result_writer.py.

Move _baseline_name to test_result_writer.py.

This function is more closely related to the code in test_result_writer.py than the code in rebaseline.py; however it wouldn't be simpler to make this function a method of TestResultWriter, since the TestResultWriter constructor takes several arguments which are not relevant to the baseline_name function.

Committed: https://crrev.com/1be7a5dd145158eee17205abb31d8506dc387bd1
Cr-Commit-Position: refs/heads/master@{#397764}

[qyearsley, 2016-05-29 21:07:56]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-29 21:08:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021743002/1

[qyearsley, 2016-05-29 21:09:31]

Description was changed from

==========
Move _baseline_name to test_result_writer.py.
==========

to

==========
Move _baseline_name to test_result_writer.py.

This function is more closely related to the code in test_result_writer.py than
the code in rebaseline.py; however it wouldn't be simpler to make this function
a method of TestResultWriter, since the TestResultWriter constructor takes
several arguments which are not relevant to the baseline_name function.
==========

[commit-bot: I haz the power, 2016-05-29 22:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-29 22:11:48]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-06-02 16:18:15]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-06-02 16:18:16]

Hi Dirk,

This change just moves the block

  # FIXME: Should TestResultWriter know how to compute this string?
  def _baseline_name(fs, test_name, suffix):
      return fs.splitext(test_name)[0] +
TestResultWriter.FILENAME_SUFFIX_EXPECTED + "." + suffix

over to test_result_writer.py.

The comment suggests that it could be a method of TestResultWriter, but the
TestResultWriter constructor takes several arguments that are not related to
this.

It would also be possible to modify TestResultWriter and/or construct a
TestResultWriter with dummy arguments in rebaseline.py, but I'm inclined to
think that just adding a global function might be simpler.

[Dirk Pranke, 2016-06-02 16:36:40]

lgtm

[qyearsley, 2016-06-03 00:19:31]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-03 00:21:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021743002/1

[commit-bot: I haz the power, 2016-06-03 00:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 00:34:42]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2016-06-03 17:32:45]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-06-03 17:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2021743002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-06-03 17:33:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021743002/20001

[commit-bot: I haz the power, 2016-06-03 18:38:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-03 18:39:42]

Description was changed from

==========
Move _baseline_name to test_result_writer.py.

This function is more closely related to the code in test_result_writer.py than
the code in rebaseline.py; however it wouldn't be simpler to make this function
a method of TestResultWriter, since the TestResultWriter constructor takes
several arguments which are not relevant to the baseline_name function.
==========

to

==========
Move _baseline_name to test_result_writer.py.

This function is more closely related to the code in test_result_writer.py than
the code in rebaseline.py; however it wouldn't be simpler to make this function
a method of TestResultWriter, since the TestResultWriter constructor takes
several arguments which are not relevant to the baseline_name function.

Committed: https://crrev.com/1be7a5dd145158eee17205abb31d8506dc387bd1
Cr-Commit-Position: refs/heads/master@{#397764}
==========

[commit-bot: I haz the power, 2016-06-03 18:39:43]

Patchset 2 (id:??) landed as
https://crrev.com/1be7a5dd145158eee17205abb31d8506dc387bd1
Cr-Commit-Position: refs/heads/master@{#397764}