Fix code-size regression

Fix code-size regression

This reinserts the native spec-string interpretation.

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of `List` from `List<E>` to `List<dynamic>` causing these native classes to be added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/565b30123c471b4b126e51f90cefab4f271c07b3

Reverted: https://github.com/dart-lang/sdk/commit/fa5b98126cd0b03163cf1e985944ef84daffe96b

Committed: https://github.com/dart-lang/sdk/commit/bb9fab00653e645ed7225506edf65c3dd74e1011

[Johnni Winther, 2016-05-30 08:57:32]

Description was changed from

==========
Fix code-size regression

This reinserts the native spec-string interpretation. The CL
https://codereview.chromium.org/2004833003/ change the interpretation of `List`
from `List<E>` to `List<dynamic>` causing these native classes to be added
through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List
==========

to

==========
Fix code-size regression

This reinserts the native spec-string interpretation. 

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of
`List` from `List<E>` to `List<dynamic>` causing these native classes to be
added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List
==========

[Johnni Winther, 2016-05-30 08:57:42]

johnniwinther@google.com changed reviewers:
+ sra@google.com

[Siggi Cherem (dart-lang), 2016-05-31 16:34:03]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-05-31 16:34:03]

Stephen - for context, this is the file where Johnni changed the interpretation
of the spec strings on that CL:
https://codereview.chromium.org/2004833003/diff/20001/pkg/compiler/lib/src/re...

[sra1, 2016-05-31 20:47:05]

lgtm

https://codereview.chromium.org/2021723003/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/2021723003/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:527: // any native subclasses of
generic classes.
Add comment that we should hunt down uses of `List` in spec strings and replace
with the correct implementation types, (likely JSArray, but possibly a union).

[Johnni Winther, 2016-06-02 08:16:51]

Description was changed from

==========
Fix code-size regression

This reinserts the native spec-string interpretation. 

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of
`List` from `List<E>` to `List<dynamic>` causing these native classes to be
added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List
==========

to

==========
Fix code-size regression

This reinserts the native spec-string interpretation.

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of
`List` from `List<E>` to `List<dynamic>` causing these native classes to be
added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/565b30123c471b4b126e51f90cefab4f271c07b3
==========

[Johnni Winther, 2016-06-02 08:16:52]

Committed patchset #2 (id:20001) manually as
565b30123c471b4b126e51f90cefab4f271c07b3 (presubmit successful).

[Johnni Winther, 2016-06-02 08:19:21]

https://codereview.chromium.org/2021723003/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/2021723003/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:527: // any native subclasses of
generic classes.
On 2016/05/31 20:47:05, sra1 wrote:
> Add comment that we should hunt down uses of `List` in spec strings and
replace
> with the correct implementation types, (likely JSArray, but possibly a union).

Done.

[Johnni Winther, 2016-06-02 11:18:01]

Description was changed from

==========
Fix code-size regression

This reinserts the native spec-string interpretation.

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of
`List` from `List<E>` to `List<dynamic>` causing these native classes to be
added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/565b30123c471b4b126e51f90cefab4f271c07b3
==========

to

==========
Fix code-size regression

This reinserts the native spec-string interpretation.

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of
`List` from `List<E>` to `List<dynamic>` causing these native classes to be
added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/565b30123c471b4b126e51f90cefab4f271c07b3

Reverted:
https://github.com/dart-lang/sdk/commit/fa5b98126cd0b03163cf1e985944ef84daffe96b
==========

[Johnni Winther, 2016-06-02 11:42:51]

PTAL at the last patch

[Johnni Winther, 2016-06-02 11:57:06]

Description was changed from

==========
Fix code-size regression

This reinserts the native spec-string interpretation.

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of
`List` from `List<E>` to `List<dynamic>` causing these native classes to be
added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/565b30123c471b4b126e51f90cefab4f271c07b3

Reverted:
https://github.com/dart-lang/sdk/commit/fa5b98126cd0b03163cf1e985944ef84daffe96b
==========

to

==========
Fix code-size regression

This reinserts the native spec-string interpretation.

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of
`List` from `List<E>` to `List<dynamic>` causing these native classes to be
added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/565b30123c471b4b126e51f90cefab4f271c07b3

Reverted:
https://github.com/dart-lang/sdk/commit/fa5b98126cd0b03163cf1e985944ef84daffe96b

Committed:
https://github.com/dart-lang/sdk/commit/bb9fab00653e645ed7225506edf65c3dd74e1011
==========

[Johnni Winther, 2016-06-02 11:57:07]

Committed patchset #4 (id:60001) manually as
bb9fab00653e645ed7225506edf65c3dd74e1011 (presubmit successful).