Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2021713002: (Heap)TerminatedArrayBuilders are stack allocated. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Heap)TerminatedArrayBuilders are stack allocated. HeapTerminatedArrayBuilder is currently only safe if kept on the stack, restrict it accordingly + have it keep a Member<> reference to the HeapTerminatedArray it is constructing. R=tkent,haraken BUG= Committed: https://crrev.com/289c5cb7e4e7d2c87fd2706325293e55289a8e9f Cr-Commit-Position: refs/heads/master@{#396677}

Patch Set 1 #

Patch Set 2 : tidy HeapTerminatedArray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArrayBuilder.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArray.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sof
please take a look.
4 years, 6 months ago (2016-05-29 20:15:22 UTC) #3
tkent
lgtm
4 years, 6 months ago (2016-05-29 23:00:00 UTC) #4
haraken
LGTM
4 years, 6 months ago (2016-05-29 23:31:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021713002/20001
4 years, 6 months ago (2016-05-30 05:18:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-30 05:21:55 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 05:23:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/289c5cb7e4e7d2c87fd2706325293e55289a8e9f
Cr-Commit-Position: refs/heads/master@{#396677}

Powered by Google App Engine
This is Rietveld 408576698