(Heap)TerminatedArrayBuilders are stack allocated.

(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=tkent,haraken
BUG=

Committed: https://crrev.com/289c5cb7e4e7d2c87fd2706325293e55289a8e9f
Cr-Commit-Position: refs/heads/master@{#396677}

[sof, 2016-05-29 20:14:55]

Description was changed from

==========
Annotate (Heap)TerminatedArrayBuilder as stack allocated.

R=
BUG=
==========

to

==========
(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=
BUG=
==========

[sof, 2016-05-29 20:15:21]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org, tkent@chromium.org

[sof, 2016-05-29 20:15:22]

please take a look.

[tkent, 2016-05-29 23:00:00]

lgtm

[haraken, 2016-05-29 23:31:59]

LGTM

[sof, 2016-05-30 05:18:13]

Description was changed from

==========
(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=
BUG=
==========

to

==========
(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=tkent,haraken
BUG=
==========

[sof, 2016-05-30 05:18:18]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-30 05:18:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021713002/20001

[commit-bot: I haz the power, 2016-05-30 05:21:54]

Description was changed from

==========
(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=tkent,haraken
BUG=
==========

to

==========
(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=tkent,haraken
BUG=
==========

[commit-bot: I haz the power, 2016-05-30 05:21:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-30 05:23:33]

Description was changed from

==========
(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=tkent,haraken
BUG=
==========

to

==========
(Heap)TerminatedArrayBuilders are stack allocated.

HeapTerminatedArrayBuilder is currently only safe if kept on the stack,
restrict it accordingly + have it keep a Member<> reference to the
HeapTerminatedArray it is constructing.

R=tkent,haraken
BUG=

Committed: https://crrev.com/289c5cb7e4e7d2c87fd2706325293e55289a8e9f
Cr-Commit-Position: refs/heads/master@{#396677}
==========

[commit-bot: I haz the power, 2016-05-30 05:23:34]

Patchset 2 (id:??) landed as
https://crrev.com/289c5cb7e4e7d2c87fd2706325293e55289a8e9f
Cr-Commit-Position: refs/heads/master@{#396677}